Pagination: Count optimization
Reported by Georg Ledermann | May 25th, 2009 @ 12:08 PM
It seems that the helpers for pagination are requesting the "count" from the database even if it's not needed.
Think about this: The given collection contains fewer elements than per_page AND there is no LIMIT statement (because :page param is not there). In this situation the count should not be calculated, because it will be same like collection.length.
In addition, regarding the tuturial (http://www.binarylogic.com/2008/9/7/tutorial-pagination-ordering-an...: It would be much better if the count-calculation is made implicit in the Searchlogic internals, the controller should NOT calculate the count (because it's not always needed, see above).
So far as I know, will_paginate implements this optimization.
Comments and changes to this ticket
-
Ben Johnson June 3rd, 2009 @ 04:00 AM
- State changed from “new” to “open”
You make some good points. What you are referring to is this line basically:
options[:last_page] ||= options[:search_obj].page_count
I know it's out of context.
But you are proposing to use the collection.size if we are on page 1 and the size is less than the per_page, if it is provided?
-
Georg Ledermann June 3rd, 2009 @ 07:58 AM
Yes. It think here is the right place for this change:
module Searchlogic module Search module Pagination ..... def page_count @page_count ||= (per_page.blank? || per_page <= 0) ? 1 : (count / per_page.to_f).ceil endReplace it with something like this:
def page_count @page_count ||= (per_page.blank? || per_page <= 0 || per_page > collection.length) ? 1 : (count / per_page.to_f).ceil end(this code does not work, I don't know how to get the collection object from within this module).
-
-
Ben Johnson June 5th, 2009 @ 03:05 PM
Hi George,
The other day I had a great idea for searchlogic v2. So I figured I would give it a shot and it turned out really nice. I'd like to show it to you because I think it will solve a lot of problems including this one. You've been pretty helpful since I released this library so I'd like to get your opinion. Heres the best part:
v1: ~3700 lines of code
v2: ~180 lines of codeSo far I am able to do just about everything I can do in v1. I would say 95% done.
Anyways, let me know if you'd like to take a look. Just give me your github username and I'll add you to the private repo. Thanks.
-
Georg Ledermann June 5th, 2009 @ 03:36 PM
Wow, this sounds great!
I like Searchlogic very much and the ideas on your weblog regarding v2 are very promising, so if I can help, I will have a look at the code in my spare time. Hopefully I can give some input... my Github username is "ledermann".
-
Ben Johnson June 5th, 2009 @ 03:39 PM
Good deal, check it out when you get a chance. I added you to the repo.
-
Ben Johnson June 20th, 2009 @ 05:00 AM
- State changed from “open” to “resolved”
Alright, I think this is resolved because of v2. Thanks!
-
nopsizerde February 24th, 2021 @ 05:46 PM
Somos un grupo de detectives instalados en la ciudad de Tarragona, Cataluña, España. Como agencia de investigación ofrecemos todos los servicios relacionados Detectives
-
nopsizerde February 24th, 2021 @ 05:52 PM
Comunidad sobre linux, ayuda, preguntas y mucho mas. muylinux.xyz
-
seomaster April 14th, 2021 @ 08:12 AM
Thanks for writing such a good article, I stumbled onto your blog and read a few post. I like your style of writing... online casino
-
seomaster April 14th, 2021 @ 08:15 AM
So it is interesting and very good written and see what they think about other people. online casino
-
seomaster April 14th, 2021 @ 08:15 AM
I wrote about a similar issue, I give you the link to my site. online casino
-
seomaster April 14th, 2021 @ 08:16 AM
In this case you will begin it is important, it again produces a web site a strong significant internet site: online casino
-
seomaster April 15th, 2021 @ 12:58 AM
Thanks for writing such a good article, I stumbled onto your blog and read a few post. I like your style of writing... casino online canada
-
seomaster April 15th, 2021 @ 01:29 AM
So it is interesting and very good written and see what they think about other people. casino online canada
-
seomaster April 15th, 2021 @ 01:29 AM
I wrote about a similar issue, I give you the link to my site. casino online canada
-
seomaster April 15th, 2021 @ 04:04 AM
In this case you will begin it is important, it again produces a web site a strong significant internet site: casino online canada
-
seomaster April 16th, 2021 @ 12:52 AM
Thanks for writing such a good article, I stumbled onto your blog and read a few post. I like your style of writing... website,
-
seomaster April 16th, 2021 @ 04:32 AM
So it is interesting and very good written and see what they think about other people. website,
-
seomaster April 16th, 2021 @ 04:32 AM
I wrote about a similar issue, I give you the link to my site. website,
-
seomaster April 16th, 2021 @ 04:38 AM
In this case you will begin it is important, it again produces a web site a strong significant internet site: website,
-
seomaster April 16th, 2021 @ 11:38 PM
Thanks for writing such a good article, I stumbled onto your blog and read a few post. I like your style of writing... online casino canada real money
-
seomaster April 17th, 2021 @ 12:07 AM
So it is interesting and very good written and see what they think about other people. online casino canada real money
-
seomaster April 17th, 2021 @ 12:07 AM
I wrote about a similar issue, I give you the link to my site. online casino canada real money
-
seomaster April 17th, 2021 @ 12:15 AM
In this case you will begin it is important, it again produces a web site a strong significant internet site: online casino canada real money
-
seomaster April 17th, 2021 @ 08:24 PM
Acknowledges for paper such a beneficial composition, I stumbled beside your blog besides decipher a limited announce. I want your technique of inscription... Lambingan
-
seomaster April 17th, 2021 @ 08:51 PM
Cool you write, the information is very good and interesting, I'll give you a link to my site. Pinoy Lambingan
-
seomaster April 17th, 2021 @ 08:51 PM
So it is interesting and very good written and see what they think about other people. Pinoy Lambingan
-
seomaster April 17th, 2021 @ 08:57 PM
You ought to basically fantastic not to mention solid advice, which means notice: Pinoy Lambingan
-
seomaster April 17th, 2021 @ 11:26 PM
Cool you write, the information is very good and interesting, I'll give you a link to my site. Pinoy Lambingan
-
seomaster April 17th, 2021 @ 11:26 PM
So it is interesting and very good written and see what they think about other people. Pinoy Lambingan
-
seomaster April 17th, 2021 @ 11:32 PM
You ought to basically fantastic not to mention solid advice, which means notice: Pinoy Lambingan
-
seomaster April 18th, 2021 @ 11:58 PM
Within this webpage, you'll see the page, you need to understand this data. kasyno online
-
seomaster April 19th, 2021 @ 12:27 AM
Beaver says I also have such interest, you can read my profile here: kasyno online
-
seomaster April 19th, 2021 @ 12:27 AM
Welcome to the party of my life here you will learn everything about me. kasyno online
-
seomaster April 19th, 2021 @ 12:38 AM
This is exciting, nevertheless it is vital for you to visit this specific url: kasyno online
-
seomaster April 19th, 2021 @ 08:36 PM
Thanks for writing such a good article, I stumbled onto your blog and read a few post. I like your style of writing... visit this page,
-
seomaster April 20th, 2021 @ 12:35 AM
So it is interesting and very good written and see what they think about other people. use all anchor equally.
-
seomaster April 20th, 2021 @ 12:35 AM
I wrote about a similar issue, I give you the link to my site. use all anchor equally.
-
seomaster April 20th, 2021 @ 12:44 AM
In this case you will begin it is important, it again produces a web site a strong significant internet site: use all anchor equally.
-
seomaster April 20th, 2021 @ 08:39 PM
Within this webpage, you'll see the page, you need to understand this data. kasyna online
-
seomaster April 20th, 2021 @ 09:14 PM
Beaver says I also have such interest, you can read my profile here: kasyna online
-
seomaster April 20th, 2021 @ 09:14 PM
Welcome to the party of my life here you will learn everything about me. kasyna online
-
seomaster April 20th, 2021 @ 09:29 PM
This is exciting, nevertheless it is vital for you to visit this specific url: kasyna online
-
seomaster April 21st, 2021 @ 11:56 PM
Thanks for writing such a good article, I stumbled onto your blog and read a few post. I like your style of writing... keno online
-
seomaster April 22nd, 2021 @ 12:23 AM
So it is interesting and very good written and see what they think about other people. keno online
-
seomaster April 22nd, 2021 @ 12:23 AM
I wrote about a similar issue, I give you the link to my site. keno online
-
seomaster April 22nd, 2021 @ 12:29 AM
In this case you will begin it is important, it again produces a web site a strong significant internet site: keno online
-
seomaster April 23rd, 2021 @ 12:11 AM
I prefer merely excellent resources - you will see these people in: ranking kasyn
-
seomaster April 23rd, 2021 @ 12:40 AM
It is quite beneficial, although think about the facts when it reaches this target. ranking kasyn
-
seomaster April 23rd, 2021 @ 12:40 AM
This is very useful, although it will be important to help simply click that web page link: ranking kasyn
-
seomaster April 23rd, 2021 @ 12:46 AM
Can nicely write on similar topics! Welcome to here you'll find out how it should look. ranking kasyn
-
seomaster April 24th, 2021 @ 08:52 PM
On this subject internet page, you'll see my best information, be sure to look over this level of detail. read more,
-
seomaster April 24th, 2021 @ 09:26 PM
Great info! I recently came across your blog and have been reading along. I thought I would leave my first comment. I don’t know what to say except that I have. go there,
-
seomaster April 24th, 2021 @ 09:26 PM
Initial You got a awesome blog .I determination be involved in plus uniform minutes. i view you got truly very functional matters , i determination be always checking your blog blesss. go there,
-
seomaster April 24th, 2021 @ 09:31 PM
I recommend only good and reliable information, so see it: go there,
-
seomaster April 26th, 2021 @ 12:53 AM
Within this webpage, you'll see the page, you need to understand this data. casino online
-
seomaster April 26th, 2021 @ 04:13 AM
Beaver says I also have such interest, you can read my profile here: casino online
-
seomaster April 26th, 2021 @ 04:13 AM
Welcome to the party of my life here you will learn everything about me. casino online
-
seomaster April 26th, 2021 @ 04:46 AM
This is exciting, nevertheless it is vital for you to visit this specific url: casino online
-
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Provides common named scopes and object based searching.
Ben Johnson