#8 ✓resolved
Paul Mason

I18n support

Reported by Paul Mason | October 14th, 2008 @ 05:50 PM

There are several spots that have English hard coded in this plugin.

Specifically, per_page_select and page_links both generate English words.

I would recommend adding a way to override these values in the options hash.

Comments and changes to this ticket

  • Ben Johnson

    Ben Johnson October 14th, 2008 @ 05:51 PM

    • State changed from “new” to “open”

    I agree, I will add in some options and have this up tonight. It should be very easy to do.

  • Ben Johnson

    Ben Johnson October 15th, 2008 @ 02:43 PM

    • State changed from “open” to “resolved”

    This is done, check out the docs. I added in new options:

    options[:text] = "%s per page"
    options[:show_all_text] = "Show all"
    

    The defaults can also be changed in the configuration.

  • Paul Mason

    Paul Mason October 15th, 2008 @ 03:35 PM

    Works great.

    Thanks for the quick turnaround on this, and keep up the amazing work!

  • Ben Johnson

    Ben Johnson October 21st, 2008 @ 04:44 PM

    Just to update, I changed the options on this. I wanted to follow the same usage that rails provides. For example in rails you would do

    select_tag "whatever", options_for_select(my_options, selected_value)
    

    in searchgasm its similar and works in the same fashion

    per_page_select(:choices => [["10 per page", 10], ["20 per page", 20], ["Show all", nil]]
    

    The default options are also a configuration option. So this should make more sense and work the same way as rails helpers.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Provides common named scopes and object based searching.

People watching this ticket

Tags

Pages