Binarylogic Searchlogic

Comments and changes to this ticket

• You flagged this item as spam.
  

  Silex October 17th, 2008 @ 12:18 PM

  Btw, the current code produces this :

  undefined method text' for 25:Fixnum

• You flagged this item as spam.
  

  Silex October 17th, 2008 @ 12:19 PM

  Whoopsy, I meant change line 279 to:

  options[:text] ||= per_page.blank? ? options[:show_all_text] : Config.per_page.text % per_page

• You flagged this item as spam.
  

  Silex October 17th, 2008 @ 12:19 PM

  AAAAARGH, with a _ instead of . :

          options[:text] ||= per_page.blank? ? options[:show_all_text] : Config.per_page_text % per_page
  
  

• You flagged this item as spam.
  

  Silex October 17th, 2008 @ 12:33 PM

  Aaaactually it's wrong again because it doens't handle the :text option properly. Here is the final fix:

        def add_per_page_link_defaults!(per_page, options = {})
          add_searchgasm_control_defaults!(:per_page, options)
          options[:show_all_text] ||= Config.per_page_show_all_text
          options[:text] ||= per_page.blank? ? options[:show_all_text] : Config.per_page_text
          options[:text] %= per_page
          options[:url] = searchgasm_params(options.merge(:search_params => {:per_page => per_page}))
          options
        end
  
  

• 

  Ben Johnson October 20th, 2008 @ 12:34 PM

  • State changed from “new” to “open”

  Thanks for letting me know about this. I will have this fixed today.

• 

  Ben Johnson October 20th, 2008 @ 10:08 PM

  • State changed from “open” to “resolved”

  This is fixed, let me know if you have any probs. I also added in a class called "ordering_by" if the link is how many items are per page.

• 

  Ben Johnson October 28th, 2008 @ 02:05 AM

  • Assigned user set to “Ben Johnson”